Use msi capabilities for chef #4949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiura
approved these changes
Jun 7, 2024
jeffreyc-splunk
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
If you want to release these changes, please bump the version in https://github.com/signalfx/splunk-otel-collector/blob/main/deployments/chef/metadata.rb#L6 and update https://github.com/signalfx/splunk-otel-collector/blob/main/deployments/chef/CHANGELOG.md.
I will release all 3 mass deployments after Puppet is done. Thanks for the reminder about that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Leverage the latest MSI capabilities so we don't rely on custom Chef code to install the collector on Windows. At this point if the user wants to install only the collector on Windows they can directly use https://docs.chef.io/resources/windows_package/
The change itself move the handling of the configuration options (env. vars) to a step before installing the MSI. The MSI properties are passed on all versions since legacy versions would simply ignore the unknown properties. The code to setup the registry is only invoked when installing a MSI version that doesn't support the install properties.
Testing: CI
Documentation:
This change is not noticeable to end users, they can keep using the same settings that they used before.