[receiver/discovery] Emit evaluation entities by the endpoint tracker #4728
Conversation
dmitryax
force-pushed
the
use-entity-state-to-report-evaluations
branch
4 times, most recently
from
72450c3 to
8ff911f
Compare
|
Should this include a changelog entry? |
I'm not sure about this. The only difference with this change is that we are sending more attributes (a superset across endpoint states and evaluations). We will need to significantly change the set of attributes later on, so I would postpone that changelog item to avoid polluting it. Let me know WDYT |
If this affects billing by sending more attributes then we should log it, otherwise it's okay with me to skip. |
|
All the entity events at this point are not expected to go outside of the collector. They are either consumed by the the discovery config provider or logged out with debug exporter |
internal/receiver/discoveryreceiver/statement_evaluator_test.go
Outdated
Show resolved
Hide resolved
dmitryax
force-pushed
the
use-entity-state-to-report-evaluations
branch
from
8ff911f to
9e986a0
Compare
This change consolidates the entity emitting in one place: endpoint tracker. Once the evaluation succeeds, the endpoint attributes are updated in the correlation store and the new entity state is emitted right away. Every subsequent state is emitted with all the added attributes. The tests are kept with minimal changes to ensure that no attributes are lost in the emitted entities. Currently, we emit superset of all the attributes that were previously emitted on regular basis or on the evaluation. Later, we will reduce the set and remove redundant attributes.
dmitryax
force-pushed
the
use-entity-state-to-report-evaluations
branch
from
9e986a0 to
ef46c5b
Compare
This change consolidates the entity emitting in one place: the endpoint tracker. Once the evaluation succeeds, the endpoint attributes are updated in the correlation store, and the new entity state is emitted immediately. Every subsequent state is emitted with all the added attributes.
Currently, we emit a superset of all the attributes that were previously emitted on a regular basis or during evaluation. Later, we will reduce the set and remove redundant attributes.
The tests are kept with minimal changes to ensure no attributes are lost in the emitted entities.