[receiver/discovery] Assign correct resource in the metric evaluation #4725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metric evaluation emits entities with attribute from the first resource in the metric batch regardless where the matching metrics were found. This change fixes the bug. The resource attributes now assigned from the resource where the metrics are found. It doesn't make sense to mention in the changelog because we don't have any pre-configured receiver that can run into this bug.
dmitryax
force-pushed
the
fix-metrics-evaluation
branch
from
17874c1 to
f3b4577
Compare
samiura
approved these changes
Apr 24, 2024
dmitryax
commented
Apr 24, 2024
| entityEvent.ID().PutStr(discovery.EndpointIDAttr, string(endpointID)) | ||
| entityState := entityEvent.SetEntityState() | ||
|
|
||
| md.ResourceMetrics().At(0).Resource().Attributes().CopyTo(entityState.Attributes()) |
There was a problem hiding this comment.
The core of the bug fix is replacing this line with line 116
There was a problem hiding this comment.
Should there be a changelog for this, or was this bug introduced since the last release? Sorry, just read the PR description 🤦
atoulme
approved these changes
Apr 24, 2024
crobert-1
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric evaluation emits entities with attributes from the first resource in the metric batch regardless of where the matching metrics were found. This change fixes the bug. The resource attributes are now assigned from the resource where the metrics are found.
It doesn't make sense to mention it in the changelog because we don't have any pre-configured receiver to run into this bug.