[receiver/discovery] Refactor correlation store to be endpoint-centric #4719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all the methods to take endpointID as the first argument. The most important change is repurposing of the attributes store. After #4717, it's not being used anymore, but this will be used to store endpoint-specific attributes. So this change migrates the field from storing receiver's attributes to storing endpoint/correlation attributes.
dmitryax
changed the title
atoulme
approved these changes
Apr 23, 2024
jinja2
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
correlationStoremethods to takeendpointIDas the first argument.The most important change is repurposing of the attributes store. After #4717, it's not being used anymore, but this will be used to store endpoint-specific attributes. So this change migrates the field from storing receiver's attributes to storing endpoint/correlation attributes.
There are no functional changes in this PR.