Improve service start stop on install ps1 #4708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Service-Start returns before the service is actually running but the code can leverage the ServiceController returned by it (when using -PassThru) to wait for the status to reach the desired state.
jinja2
reviewed
Apr 23, 2024
internal/buildscripts/packaging/choco/splunk-otel-collector/tools/chocolateyinstall.ps1
Show resolved
Hide resolved
jinja2
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Better leverage the Powershell Service cmdlets to reduce code and to not stop the service if it didn't start in the given starting timeout (there is no point: if the service is taking long to start, stopping it will just ensure that it will start from zero again).