Skip to content

Add env var SPLUNK_CONFIG_YAML for storing configuration YAML #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

bjsignalfx
Copy link
Contributor

@bjsignalfx bjsignalfx commented Jun 9, 2021

Supplying Splunk Otel Collector configuration yaml via environment variable SPLUNK_CONFIG_YAML.

One advantage is that this allows for having the config YAML as a parameter value in AWS Systems Manager Parameter Store and thus removing the need to have a volume mounted to a Fargate task to hold the configuration file.

@bjsignalfx bjsignalfx requested review from a team as code owners June 9, 2021 22:26
@bjsignalfx bjsignalfx force-pushed the config-yaml-envvar branch from 312f802 to a471b51 Compare June 10, 2021 14:26
@rmfitzpatrick
Copy link
Contributor

Would you be comfortable setting #450 as the base branch? They will be stepping on each other otherwise.

Also it would be good to document this in places like https://github.com/signalfx/splunk-otel-collector/blob/main/docs/getting-started/linux-manual.md#custom-configuration

@bjsignalfx
Copy link
Contributor Author

It looks like #450 is ready to be merge. If so, maybe merge then I rebase main? And yes I'll add documentation.

@bjsignalfx bjsignalfx requested review from dmitryax, flands and rmfitzpatrick and removed request for flands, dmitryax and rmfitzpatrick June 10, 2021 15:52
@bjsignalfx
Copy link
Contributor Author

bjsignalfx commented Jun 10, 2021

@rmfitzpatrick So, if SPLUNK_CONFIG and SPLUNK_CONFIG_YAML are specified, which should take precedence? Maybe we should make these mutually exclusive because of equal precedence?

@rmfitzpatrick
Copy link
Contributor

It looks like #450 is ready to be merge. If so, maybe merge then I rebase main? And yes I'll add documentation.

I'm still waiting for a final review and will likely be merging tomorrow if it doesn't come in.

@rmfitzpatrick So, if SPLUNK_CONFIG and SPLUNK_CONFIG_YAML are specified, which should take precedence? Maybe we should make these mutually exclusive because of equal precedence?

I think it makes sense they should be mutually exclusive (w/ --config) always taking priority.

@bjsignalfx bjsignalfx force-pushed the config-yaml-envvar branch from a471b51 to 32ceac9 Compare June 11, 2021 20:56
@rmfitzpatrick
Copy link
Contributor

@tmorrisonsfx
Copy link

@bjsignalfx I reviewed the linux-manual.md file. Included a few suggested changes. Thanks!

@bjsignalfx bjsignalfx force-pushed the config-yaml-envvar branch from 099ccf6 to 29dd599 Compare July 1, 2021 16:44
@bjsignalfx bjsignalfx force-pushed the config-yaml-envvar branch from 260dfc0 to ceb8edc Compare July 1, 2021 20:53
@bjsignalfx bjsignalfx force-pushed the config-yaml-envvar branch from f421729 to 1ae5f05 Compare July 6, 2021 03:53
@bjsignalfx bjsignalfx force-pushed the config-yaml-envvar branch 2 times, most recently from 1f6eb34 to 7a1bfd3 Compare July 13, 2021 16:54
@bjsignalfx bjsignalfx force-pushed the config-yaml-envvar branch from 7a1bfd3 to 6650dea Compare July 13, 2021 19:35
@bjsignalfx bjsignalfx merged commit f60a618 into main Jul 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the config-yaml-envvar branch July 14, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants