-
Notifications
You must be signed in to change notification settings - Fork 166
Add env var SPLUNK_CONFIG_YAML for storing configuration YAML #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
312f802
to
a471b51
Compare
Would you be comfortable setting #450 as the base branch? They will be stepping on each other otherwise. Also it would be good to document this in places like https://github.com/signalfx/splunk-otel-collector/blob/main/docs/getting-started/linux-manual.md#custom-configuration |
It looks like #450 is ready to be merge. If so, maybe merge then I rebase main? And yes I'll add documentation. |
@rmfitzpatrick So, if SPLUNK_CONFIG and SPLUNK_CONFIG_YAML are specified, which should take precedence? Maybe we should make these mutually exclusive because of equal precedence? |
I'm still waiting for a final review and will likely be merging tomorrow if it doesn't come in.
I think it makes sense they should be mutually exclusive (w/ |
a471b51
to
32ceac9
Compare
8ff65f4
to
5eff2f6
Compare
90512d4
to
29b78f5
Compare
@bjsignalfx I reviewed the linux-manual.md file. Included a few suggested changes. Thanks! |
099ccf6
to
29dd599
Compare
260dfc0
to
ceb8edc
Compare
f421729
to
1ae5f05
Compare
1f6eb34
to
7a1bfd3
Compare
7a1bfd3
to
6650dea
Compare
Supplying Splunk Otel Collector configuration yaml via environment variable SPLUNK_CONFIG_YAML.
One advantage is that this allows for having the config YAML as a parameter value in AWS Systems Manager Parameter Store and thus removing the need to have a volume mounted to a Fargate task to hold the configuration file.