[receiver/discovery] Remove first_only field from the matching rule

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - (Splunk) `receiver/discovery`: Update metrics and logs evaluation statements schema:
   - Remove `severity_text` field from log evaluation statements ([#4583](https://github.com/signalfx/splunk-otel-collector/pull/4583))
+  - Remove `first_only`  field from match struct. Events are always emitted only once for first matching metric or log statement ([#4593](https://github.com/signalfx/splunk-otel-collector/pull/4593))
   - Combine matching conditions with different statuses in one list ([#4588](https://github.com/signalfx/splunk-otel-collector/pull/4588))
 
 ## v0.97.0

cmd/otelcol/config/collector/config.d.linux/receivers/mysql.discovery.yaml

@@ -20,19 +20,16 @@
 #     metrics:
 #       - status: successful
 #         strict: mysql.locks
-#         first_only: true
 #         log_record:
 #           body: Mysql receiver is working!
 #     statements:
 #       - status: failed
 #         regexp: "Can't connect to MySQL server on .* [(]111[)]"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body:  The container cannot be reached by the Collector. The container is refusing MySQL connections.
 #       - status: partial
 #         regexp: 'Access denied for user'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-

cmd/otelcol/config/collector/config.d.linux/receivers/oracledb.discovery.yaml

@@ -21,37 +21,31 @@
 #     metrics:
 #       - status: successful
 #         strict: oracledb.cpu_time
-#         first_only: true
 #         log_record:
 #           body: oracledb receiver is working!
 #     statements:
 #       - status: failed
 #         regexp: "connection refused"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container is not serving http connections.
 #       - status: failed
 #         regexp: "received goaway and there are no active streams"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: Unable to connect and scrape metrics.
 #       - status: failed
 #         regexp: "dial tcp: lookup"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: Unable to resolve oracledb tcp endpoint
 #       - status: failed
 #         regexp: 'error executing select .*: EOF'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: Unable to execute select from oracledb. Verify endpoint and user permissions.
 #       - status: partial
 #         regexp: "listener does not currently know of service requested"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -60,7 +54,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_oracledb_CONFIG_service="<service>"` environment variable.
 #       - status: partial
 #         regexp: 'invalid username/password'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-

cmd/otelcol/config/collector/config.d.linux/receivers/postgresql.discovery.yaml

@@ -20,25 +20,21 @@
 #     metrics:
 #       - status: successful
 #         strict: postgresql.commits
-#         first_only: true
 #         log_record:
 #           body: PostgreSQL receiver is working!
 #     statements:
 #       - status: failed
 #         regexp: 'connect: network is unreachable'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container cannot be reached by the Collector. Make sure they're in the same network.
 #       - status: failed
 #         regexp: 'connect: connection refused'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container is refusing PostgreSQL connections.
 #       - status: partial
 #         regexp: 'pq: password authentication failed for user'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -49,7 +45,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_postgresql_CONFIG_password="<password>"` environment variables.
 #       - status: partial
 #         regexp: 'pq: database .* does not exist'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -58,7 +53,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_postgresql_CONFIG_databases="[<db>]"` environment variable.
 #       - status: partial
 #         regexp: 'pq: SSL is not enabled on the server'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -67,7 +61,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_postgresql_CONFIG_tls_x3a__x3a_insecure="<boolean>"` environment variable.
 #       - status: partial
 #         regexp: 'pq: pg_stat_statements must be loaded via shared_preload_libraries'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-

cmd/otelcol/config/collector/config.d.linux/receivers/redis.discovery.yaml

@@ -18,31 +18,26 @@
 #     metrics:
 #       - status: successful
 #         strict: redis.uptime
-#         first_only: true
 #         log_record:
 #           body: redis receiver is working!
 #     statements:
 #       - status: failed
 #         regexp: "connection refused"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container is not serving http connections.
 #       - status: failed
 #         regexp: "received goaway and there are no active streams"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: Unable to connect and scrape metrics.
 #       - status: failed
 #         regexp: "dial tcp: lookup"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: Unable to resolve redis tcp endpoint
 #       - status: partial
 #         regexp: 'NOAUTH Authentication required.'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -53,7 +48,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_redis_CONFIG_password="<password>"` environment variables.
 #       - status: partial
 #         regexp: 'called without any password configured for the default user'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -62,7 +56,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_redis_CONFIG_password="<password>"` environment variables.
 #       - status: partial
 #         regexp: 'WRONGPASS invalid username-password pair or user is disabled'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-

cmd/otelcol/config/collector/config.d.linux/receivers/smartagent-collectd-mysql.discovery.yaml

@@ -24,19 +24,16 @@
 #     metrics:
 #       - status: successful
 #         strict: mysql_octets.rx
-#         first_only: true
 #         log_record:
 #           body: smartagent/collectd/mysql receiver is working!
 #     statements:
 #       - status: failed
 #         regexp: "mysql plugin: Failed to connect to database .* at server .* Can't connect to MySQL server on .* [(]111[)]"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container is refusing MySQL connections.
 #       - status: partial
 #         regexp: 'mysql plugin: Failed to connect to database .* at server .* Access denied for user .* [(]using password: .*[)]'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -47,7 +44,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_smartagent_x2f_collectd_x2f_mysql_CONFIG_password="<password>"` environment variables.
 #       - status: partial
 #         regexp: 'mysql plugin: Failed to connect to database .* at server .* Unknown database'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -56,7 +52,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_smartagent_x2f_collectd_x2f_mysql_CONFIG_databases="[{name: '<db-name-0>'}, {name: '<db-name-1>', username: '<username>', password: '<password>'}]"` environment variable.
 #       - status: partial
 #         regexp: 'mysql plugin: Failed to connect to database .* at server .* Access denied for user .* to database'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-

cmd/otelcol/config/collector/config.d.linux/receivers/smartagent-collectd-nginx.discovery.yaml

@@ -22,19 +22,16 @@
 #     metrics:
 #       - status: successful
 #         strict: connections.accepted
-#         first_only: true
 #         log_record:
 #           body: smartagent/collectd/nginx receiver is working!
 #     statements:
 #       - status: failed
 #         regexp: "nginx plugin: curl_easy_perform failed: Operation timed out after"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container is not serving http connections.
 #       - status: failed
 #         regexp: "read-function of plugin .* failed"
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The integration is unable to read metrics from this endpoint.

cmd/otelcol/config/collector/config.d.linux/receivers/smartagent-postgresql.discovery.yaml

@@ -24,12 +24,10 @@
 #     metrics:
 #       - status: successful
 #         strict: postgres_query_count
-#         first_only: true
 #         log_record:
 #           body: PostgreSQL receiver is working!
 #       - status: partial
 #         strict: postgres_rows_inserted
-#         first_only: true
 #         log_record:
 #           body: >-
 #             Make sure that
@@ -40,19 +38,16 @@
 #     statements:
 #       - status: failed
 #         regexp: 'connect: network is unreachable'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container cannot be reached by the Collector. Make sure they're in the same network.
 #       - status: failed
 #         regexp: 'connect: connection refused'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: The container is refusing PostgreSQL connections.
 #       - status: partial
 #         regexp: 'pq: password authentication failed for user'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -63,7 +58,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_smartagent_x2f_postgresql_CONFIG_params_x3a__x3a_password="<password>"` environment variables.
 #       - status: partial
 #         regexp: 'pq: database .* does not exist'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-
@@ -72,7 +66,6 @@
 #             `SPLUNK_DISCOVERY_RECEIVERS_smartagent_x2f_postgresql_CONFIG_masterDBName="<db>"` environment variable.
 #       - status: partial
 #         regexp: 'pq: pg_stat_statements must be loaded via shared_preload_libraries'
-#         first_only: true
 #         log_record:
 #           append_pattern: true
 #           body: >-

internal/confmapprovider/discovery/bundle/README.md

@@ -29,7 +29,6 @@ Example `redis.discovery.yaml.tmpl`:
     statements:
       partial:
         - regexp: 'ERR AUTH.*'
-          first_only: true
           log_record:
             body: >-
               Please ensure your redis password is correctly specified with
@@ -54,7 +53,6 @@ redis:
     statements:
       partial:
         - regexp: 'ERR AUTH.*'
-          first_only: true
           log_record:
             body: >-
               Please ensure your redis password is correctly specified with

internal/confmapprovider/discovery/bundle/bundle.d/receivers/mysql.discovery.yaml

@@ -16,19 +16,16 @@ mysql:
     metrics:
       - status: successful
         strict: mysql.locks
-        first_only: true
         log_record:
           body: Mysql receiver is working!
     statements:
       - status: failed
         regexp: "Can't connect to MySQL server on .* [(]111[)]"
-        first_only: true
         log_record:
           append_pattern: true
           body:  The container cannot be reached by the Collector. The container is refusing MySQL connections.
       - status: partial
         regexp: 'Access denied for user'
-        first_only: true
         log_record:
           append_pattern: true
           body: >-

internal/confmapprovider/discovery/bundle/bundle.d/receivers/mysql.discovery.yaml.tmpl

@@ -12,19 +12,16 @@
     metrics:
       - status: successful
         strict: mysql.locks
-        first_only: true
         log_record:
           body: Mysql receiver is working!
     statements:
       - status: failed
         regexp: "Can't connect to MySQL server on .* [(]111[)]"
-        first_only: true
         log_record:
           append_pattern: true
           body:  The container cannot be reached by the Collector. The container is refusing MySQL connections.
       - status: partial
         regexp: 'Access denied for user'
-        first_only: true
         log_record:
           append_pattern: true
           body: >-

internal/confmapprovider/discovery/bundle/bundle.d/receivers/oracledb.discovery.yaml

@@ -17,37 +17,31 @@ oracledb:
     metrics:
       - status: successful
         strict: oracledb.cpu_time
-        first_only: true
         log_record:
           body: oracledb receiver is working!
     statements:
       - status: failed
         regexp: "connection refused"
-        first_only: true
         log_record:
           append_pattern: true
           body: The container is not serving http connections.
       - status: failed
         regexp: "received goaway and there are no active streams"
-        first_only: true
         log_record:
           append_pattern: true
           body: Unable to connect and scrape metrics.
       - status: failed
         regexp: "dial tcp: lookup"
-        first_only: true
         log_record:
           append_pattern: true
           body: Unable to resolve oracledb tcp endpoint
       - status: failed
         regexp: 'error executing select .*: EOF'
-        first_only: true
         log_record:
           append_pattern: true
           body: Unable to execute select from oracledb. Verify endpoint and user permissions.
       - status: partial
         regexp: "listener does not currently know of service requested"
-        first_only: true
         log_record:
           append_pattern: true
           body: >-
@@ -56,7 +50,6 @@ oracledb:
             `SPLUNK_DISCOVERY_RECEIVERS_oracledb_CONFIG_service="<service>"` environment variable.
       - status: partial
         regexp: 'invalid username/password'
-        first_only: true
         log_record:
           append_pattern: true
           body: >-