add discovery config converter to respect existing service config #2986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
discoveryconverter
branch
from
38ca4a9 to
ca2b7d4
Compare
theletterf
approved these changes
Apr 18, 2023
jvoravong
reviewed
Apr 18, 2023
jvoravong
approved these changes
Apr 18, 2023
rmfitzpatrick
force-pushed
the
discoveryconverter
branch
from
ca2b7d4 to
a455938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial behavior of discovery mode for receiver and extension suggestions was destructive to existing service config* components. These changes add a new discovery config converter to append the components by way of temporary
service::extensions/splunk.discoveryandservice::receivers/splunk.discoveryintermediaries.