-
Notifications
You must be signed in to change notification settings - Fork 166
[deployment/chef] Fix custom variables handling on Windows #6271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6271 +/- ##
==========================================
- Coverage 44.90% 44.90% -0.01%
==========================================
Files 390 390
Lines 26994 26994
==========================================
- Hits 12123 12121 -2
- Misses 14003 14008 +5
+ Partials 868 865 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM. Left a comment for recommendations for how to create related releases, if this PR is updated to change the release strategy that is acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the failure is well known and being tracked separately
Description:
This fixes how Chef handles custom variables for the
splunk-otel-collector
on Windows deployments. The MSI doesn't support custom variables, it supports a set of known variables. To properly set custom variables we need to use the registry.Also, update version of the collector being used in testing.