Skip to content

[deployment/chef] Fix custom variables handling on Windows #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 3, 2025

Conversation

crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented May 30, 2025

Description:

This fixes how Chef handles custom variables for the splunk-otel-collector on Windows deployments. The MSI doesn't support custom variables, it supports a set of known variables. To properly set custom variables we need to use the registry.

Also, update version of the collector being used in testing.

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.90%. Comparing base (e26dffc) to head (71238d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6271      +/-   ##
==========================================
- Coverage   44.90%   44.90%   -0.01%     
==========================================
  Files         390      390              
  Lines       26994    26994              
==========================================
- Hits        12123    12121       -2     
- Misses      14003    14008       +5     
+ Partials      868      865       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 changed the title [chore][deployment/chef] Upgrade version of Collector used in testing [deployment/chef] Fix custom variables handling on Windows Jun 2, 2025
@crobert-1 crobert-1 marked this pull request as ready for review June 2, 2025 21:13
@crobert-1 crobert-1 requested review from a team as code owners June 2, 2025 21:13
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. Left a comment for recommendations for how to create related releases, if this PR is updated to change the release strategy that is acceptable.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the failure is well known and being tracked separately

@crobert-1 crobert-1 merged commit 74f2583 into signalfx:main Jun 3, 2025
77 of 78 checks passed
@crobert-1 crobert-1 deleted the upgrade_otelcol_chef branch June 3, 2025 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants