Skip to content

[chore][installer-script-test] Upgrade minimum version of Node.js to v18 in testing #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented May 19, 2025

Description:

Test failure output from linux-installer-script-test:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@splunk/[email protected]',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

Failure link

NOTE: v16 has been EOL since August 2023. v18 is also EOL, but I think it makes sense to upgrade one major version at a time for now.

@crobert-1 crobert-1 changed the title [chore][installer-tests] Upgrade minimum node version to 18 [chore][installer-tests] Upgrade minimum version of Node.js to v18 in testing May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.01%. Comparing base (8a58ae5) to head (1906aca).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (34.01%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (8a58ae5) and HEAD (1906aca). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (8a58ae5) HEAD (1906aca)
35 22
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6235       +/-   ##
===========================================
- Coverage   44.35%   34.01%   -10.34%     
===========================================
  Files         390      390               
  Lines       26986    26986               
===========================================
- Hits        11969     9179     -2790     
- Misses      14171    17181     +3010     
+ Partials      846      626      -220     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 marked this pull request as ready for review May 19, 2025 22:39
@crobert-1 crobert-1 requested review from a team as code owners May 19, 2025 22:39
@crobert-1 crobert-1 changed the title [chore][installer-tests] Upgrade minimum version of Node.js to v18 in testing [chore][installer-script-test] Upgrade minimum version of Node.js to v18 in testing May 19, 2025
@crobert-1 crobert-1 merged commit 5b03c26 into signalfx:main May 19, 2025
212 of 213 checks passed
@crobert-1 crobert-1 deleted the fix_install_script_test branch May 19, 2025 22:42
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants