Disable opencensus.resourcetype attribute in cluster_receiver #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
remove-redundant-cluster-receiver-attribute
branch
3 times, most recently
from
b690e9c to
3e7b184
Compare
jvoravong
approved these changes
Sep 6, 2023
dmitryax
force-pushed
the
remove-redundant-cluster-receiver-attribute
branch
from
6b2f248 to
8278797
Compare
Disable a redundant `opencensus.resourcetype` resource attribute in k8s_cluster receiver. The attribute will be removed from the receiver upstream anyway, but this will happen in a deprecation process, so we need to put this config in the receiver to avoid throwing deprecation warnings.
This change doe not affect Splunk Observability users, because it has been already disabled in the signalfx exporter default translation rules.
This can be a breaking change for Splunk Platform users relying on this attribute. If required, it can added back by configuring an additional `resource` processor.
```
clusterReceiver:
config:
processors:
resource/add_opencensus_resourcetype:
attributes:
- action: insert
key: opencensus.resourcetype
value: k8s
service:
pipelines:
metrics:
processors:
- memory_limiter
- batch
- resource
- resource/k8s_cluster
- resource/add_opencensus_resourcetype
```
dmitryax
force-pushed
the
remove-redundant-cluster-receiver-attribute
branch
from
8278797 to
6d07948
Compare
dmitryax
added a commit
to dmitryax/splunk-otel-collector-chart
that referenced
this pull request
Sep 6, 2023
This change disables signalfx exporter default translations the clusterReceiver deploymentto avoid wasting CPU cycles. Removing of `opencensus.resourcetype` attribute was the only translation applicable to k8s_cluster receiver metrics. After it the attribute was disabled on the receiver side in signalfx#914, the default translations are not needed anymore. This can be a breaking change for Splunk Observability users who use the deprecated `translation_rules` option in signalfx exporter in clusterReceiver. The option has been deprecated for more than half a year, so we should encourage users to not use it anymore.
dmitryax
added a commit
that referenced
this pull request
Sep 6, 2023
This change disables signalfx exporter default translations the clusterReceiver deploymentto avoid wasting CPU cycles. Removing of `opencensus.resourcetype` attribute was the only translation applicable to k8s_cluster receiver metrics. After it the attribute was disabled on the receiver side in #914, the default translations are not needed anymore. This can be a breaking change for Splunk Observability users who use the deprecated `translation_rules` option in signalfx exporter in clusterReceiver. The option has been deprecated for more than half a year, so we should encourage users to not use it anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable a redundant
opencensus.resourcetyperesource attribute in k8s_cluster receiver. The attribute will be removed from the receiver upstream anyway, but this will happen in a deprecation process, so we need to put this config in the receiver to avoid throwing deprecation warnings.This change doe not affect Splunk Observability users, because it has been already disabled in the signalfx exporter default translation rules.
This can be a breaking change for Splunk Platform users relying on this attribute. If required, it can added back by configuring an additional
resourceprocessor the following way: