Upgrade NodeJS instrumentation to v3.1.2 #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pjanotti
commented
Apr 25, 2025
| @@ -153,7 +153,7 @@ Helper for generating environment variables for each instrumentation library. | |||
|
|
|||
| {{- /* Handle custom or default exporter endpoint */ -}} | |||
| {{- $customOtelExporterEndpoint := "" }} | |||
| {{- if or (eq .instLibName "dotnet") (eq .instLibName "python") (eq .instLibName "java") }} | |||
| {{- if or (eq .instLibName "dotnet") (eq .instLibName "java") (eq .instLibName "nodejs") (eq .instLibName "python") }} | |||
| {{- $customOtelExporterEndpoint = .endpoint | replace ":4317" ":4318" }} | |||
There was a problem hiding this comment.
We should consider if we still have cases that need this conditional. In principle we could just default to 4318.
pjanotti
commented
Apr 25, 2025
| @@ -68,6 +68,12 @@ jobs: | |||
| - name: Update dependencies | |||
| run: | | |||
| make dep-update | |||
| - name: Temporary generate new nodejs image - do not upload it | |||
There was a problem hiding this comment.
Currently these images a pushed to quay.io in a separate step. This specific image is not that expensive to build, but, to facilitate upgrades that require changes to the test images we may want to consider saving the needed images as workflow artifacts instead of publishing them to quay.io
There was a problem hiding this comment.
That might help. That can be tracked separately.
hughesjj
approved these changes
Apr 25, 2025
hughesjj
approved these changes
Apr 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade NodeJS instrumentation to v3.1.2 - supersedes #1744