[chore] add logic to update our tests k8s versions

[dloucasfx]

Description:
Added a utility to get a list of supported vanilla k8s clusters, compare it to our test k8s versions and update when necessary.

I added a make target, which we can keep or remove, but the end goal is to add a gh action that uses this logic to create a PR with the changes if detected.

We currently have a bunch of EOL k8s versions that we use, it's a way to check compatibility with cloud providers that extend the support.
This is not ideal as we keep increasing our test matrix and the vanilla cluster is not identical to the one used by the cloud provider. To test for schema compatibility, we should start using kubeconform

To Do (sperate PRs):

• Add a gh action
• track EKS, AKS and GKE

Testing:
unit test

[pjanotti]

Nice!

[crobert-1]

Looks good! With all of my comments feel free to drop or clarify as you see fit. I'm generally trying to reduce regexes and string parsing logic as much as possible. I'd be happy to discuss any options here.

[crobert-1]

Sorry about all of the nits, once the formatting tools are introduced to the repo it'll catch earlier on in the process.

[dloucasfx]

New push:

• Addressed most of the review entries. For var shadowing, I only addressed the linter errors as the others are not necessary
• Updated the golangci config to force strict shadow detection and excluded this tool from gosec to prevent unnecessary detections (addressing this in a separate PR)

tools/k8s_versions/update_k8s_versions.go:197:11: G306: Expect WriteFile permissions to be 0600 or less (gosec)
        if err = os.WriteFile(filePath, updatedContent, 0644); err != nil {
                 ^
tools/k8s_versions/update_k8s_versions.go:218:15: G107: Potential HTTP request made with variable url (gosec)
        resp, err := http.Get(url)
      

• Rebased and resolved conflicts

[crobert-1]

Once this PR has been rebased on main we can drop all of my shadowing err issues. main now has lint checks running on PRs so once lint passes on this PR my concerns are resolved 👍

[dloucasfx]

Once this PR has been rebased on main we can drop all of my shadowing err issues. main now has lint checks running on PRs so once lint passes on this PR my concerns are resolved 👍

@crobert-1
Pushed the following changes:

• rebased
• Added Makefile in the directory to reference the common makefile
• Addressed @dmitryax comment [chore] add logic to update our tests k8s versions #1792 (comment)
• Fixed gosec G107 by using url parse

tools/k8s_versions/update_k8s_versions.go:220:15: G107: Potential HTTP request made with variable url (gosec)
        resp, err := http.Get(url)

• The only lint that is failing now is

tools/k8s_versions/update_k8s_versions.go:199:11: G306: Expect WriteFile permissions to be 0640 or less (gosec)
        if err = os.WriteFile(filePath, updatedContent, 0o644); err != nil {

This is very restrictive, not if we want to no lint it or change the G306 gosec config to

    config:
      # Maximum allowed permissions mode for os.OpenFile and os.Chmod
      # Default: "0600"
      G306: "0644"

[crobert-1]

This is very restrictive, not if we want to no lint it or change the G306 gosec config to

I'd say for now my preference is to just add a nolint comment. I generally prefer getting warnings up front on new changes to let us make an educated decision on a case by case basis. Happy to hear from others though 👍

[crobert-1]

LGTM once CI is passing. Thanks for all of your work here @dloucasfx!

[dmitryax]

LGTM. Can be merged once the minor comment is addressed

[dmitryax]

It's called the patch version in semver :)

Suggested change

	func decrementMinorMinorVersion(version string) (string, error) {
	func decrementPatchVersion(version string) (string, error) {

[dloucasfx]

roger that!

[jinja2]

@dloucasfx We have some tests which use the K8S_VERSION var to look up for expected test data since the metrics change with k8s version for some receiver. These tests (i can only remember histograms from the top of my head) will probably start failing once a new minor version is introduced by this workflow. I took a look at the code and don't see this being addressed. Is this known? we can fix the tests once the new version is added or we could probably just copy the data from new minor version - 1 when the workflow runs.