Remove smartagent/signalfx-forwarder from the agent default config

[dmitryax]

The old SignalFx instrumentation libraries are not supported anymore. So we don't need to keep the forwarder in the default config. Use Splunk OpenTelemetry instrumentation libraries to send traces in OTLP format instead.

If you need to keep the receiver for longer, add the following section to your values.yaml file:

agent:
  ports:
    sfx-forwarder:
      containerPort: 9080
      hostPort: 9080
      protocol: TCP
      enabled_for: [traces]
  config:
    receivers:
      smartagent/signalfx-forwarder:
        listenAddress: 0.0.0.0:9080
        type: signalfx-forwarder
    service:
      pipelines:
        traces:
          receivers:
            - otlp
            - jaeger
            - smartagent/signalfx-forwarder
            - zipkin

[dloucasfx]

PR looks good!
My only question is communicating this change and making the user aware of it.
Do we have customers pointing their instrumented apps to 9080?

[dmitryax]

Do we have customers pointing their instrumented apps to 9080?

Only if they use the old SignalFx instrumentation libraries which are not supported anymore