Introduce image.otelcol.fips which set the appropriate repo/image and skips migrate-checkpoint if needed #1756
Conversation
… skips migrate-checkpoint if needed Signed-off-by: Dani Louca <[email protected]>
| # The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other) | ||
| component: all | ||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Introduce a new option `image.otelcol.fips`, when set to true, it sets the appropriate repo/image and skips `migrate-checkpoint` when log is enabled |
There was a problem hiding this comment.
Are we officially rolling out our FIPs image? I am asking cause we have previously closed similarly PRs and have been waiting for green light from product.
There was a problem hiding this comment.
I was not aware of this PR, I wonder if this is the same user who reported it internally.
The workaround provided in the linked PR is not ideal as you will loose some functionalities by skipping all init containers.
As for the fips image support, this implies https://github.com/signalfx/splunk-otel-collector-chart/blob/main/helm-charts/splunk-otel-collector/values.yaml#L976 that it's supported.
|
The histogram tests are failing due to a flaky coredns metric |
|
We decided another approach, see #1757 |
Description:
FIPS images do not support migratecheckpoint to migrate checkpoints from fluentd when
logsEnabledis set , this causes the pod to get into a crashloop.The fix introduces a new
image.otelcol.fipsoption, which will be used to set the default repo/image and skipsmigratecheckpointinit container if needed.The default repo logic is moved into
splunk-otel-collector.image.otelcolhelper function so user can still set a custom repo if needed.