[job] Add a job to block release if main branch is broken #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
add-job-blocking-release-if-main-is-broken
branch
4 times, most recently
from
ec39ea7 to
abfd8a0
Compare
jinja2
reviewed
Mar 7, 2025
| run: | | ||
| response=$(curl -s \ | ||
| -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \ | ||
| "https://api.github.com/repos/${{ github.repository }}/commits/main/status") |
There was a problem hiding this comment.
Do you know if this gets the status of the last completed run? or of runs in progress too? The workflow run endpoint gives a status and conclusion to differentiate this https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks#check-statuses-and-conclusions. Not sure if this is a concern here.
There was a problem hiding this comment.
Good question. I don't know. Looks like it should be the last commit status only including in_progress. But let me print the fetched status so we can easily debug if needed
dmitryax
force-pushed
the
add-job-blocking-release-if-main-is-broken
branch
from
abfd8a0 to
9b4980f
Compare
|
Closing this for now. Let's make functional tests stable and make them required instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.