-
Notifications
You must be signed in to change notification settings - Fork 166
Fix metrics sourcetype annotation #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jvoravong
merged 13 commits into
signalfx:main
from
mstopa-splunk:fix_metrics_sourcetype_annotation
Mar 18, 2025
Merged
Fix metrics sourcetype annotation #1375
jvoravong
merged 13 commits into
signalfx:main
from
mstopa-splunk:fix_metrics_sourcetype_annotation
Mar 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/disable-persistence-queue-traces/rendered_manifests/configmap-agent.yaml
Show resolved
Hide resolved
jvoravong
reviewed
Oct 14, 2024
jvoravong
reviewed
Oct 14, 2024
jvoravong
reviewed
Oct 14, 2024
@jvoravong thank you for the last review, can you please check the updated PR? |
pszkamruk-splunk
approved these changes
Mar 18, 2025
jvoravong
approved these changes
Mar 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixed updating metrics' sourcetype with annotations
Link to Splunk idea:
Testing: Added a new unit test
Documentation: Added
splunk.com/metricsSourceType
toadvanced-configuration.md