Skip to content

[agent] Add support for histograms with control plane metrics #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 28, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 6, 2024

Description:
Add support for histograms with control plane metrics behind a feature gate.

@atoulme atoulme requested review from a team as code owners August 6, 2024 22:45
@atoulme atoulme force-pushed the controlplanemetrics_histogram branch from 01e87d0 to 901de81 Compare August 6, 2024 22:45
@jvoravong
Copy link
Contributor

jvoravong commented Aug 8, 2024

We also probably have to tackle updating the not-openshift rules for the receivers to values like these. This way we include rules for older and current labels of control plane pods, testing might be blocked if the new labels are not added.

       rule: type == "pod" && (labels["k8s-app"] == "kube-dns" ||  || (labels["tier"] == "control-plane" && labels["component"] == "kube-dns"))
       rule: type == "pod" && (labels["k8s-app"] == "etcd-manager-events" || labels["k8s-app"] == "etcd-manager-main" || (labels["tier"] == "control-plane" && labels["component"] == "etcd"))
       rule: type == "pod" && (labels["k8s-app"] == "kube-controller-manager" || (labels["tier"] == "control-plane" && labels["component"] == "kube-controller-manager"))
       rule: type == "port" && port == 443 && (labels["k8s-app"] == "kube-apiserver" || (labels["tier"] == "control-plane" && labels["component"] == "kube-apiserver"))
       rule: type == "pod" && (labels["k8s-app"] == "kube-proxy" || (labels["tier"] == "control-plane" && labels["component"] == "kube-proxy"))
       rule: type == "pod" && (labels["k8s-app"] == "kube-scheduler" || (labels["tier"] == "control-plane" && labels["component"] == "kube-scheduler"))

@atoulme atoulme force-pushed the controlplanemetrics_histogram branch from dfbb43c to 7af288e Compare August 8, 2024 18:19
@atoulme atoulme force-pushed the controlplanemetrics_histogram branch 9 times, most recently from a285a82 to 20cdc95 Compare August 22, 2024 05:00
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since these changes are behind a feature gate. You might still need to pull latest changes from main.

@atoulme atoulme force-pushed the controlplanemetrics_histogram branch from f444e26 to 8baaedb Compare August 27, 2024 15:55
@atoulme atoulme force-pushed the controlplanemetrics_histogram branch from 8baaedb to d6392ea Compare August 28, 2024 01:21
@atoulme atoulme merged commit b2a318c into main Aug 28, 2024
40 of 42 checks passed
@atoulme atoulme deleted the controlplanemetrics_histogram branch August 28, 2024 01:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants