-
Notifications
You must be signed in to change notification settings - Fork 166
[agent] Add support for histograms with control plane metrics #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
01e87d0
to
901de81
Compare
examples/controlplane-histogram-metrics/rendered_manifests/configmap-agent.yaml
Outdated
Show resolved
Hide resolved
We also probably have to tackle updating the not-openshift rules for the receivers to values like these. This way we include rules for older and current labels of control plane pods, testing might be blocked if the new labels are not added.
|
dfbb43c
to
7af288e
Compare
a285a82
to
20cdc95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since these changes are behind a feature gate. You might still need to pull latest changes from main.
f444e26
to
8baaedb
Compare
8baaedb
to
d6392ea
Compare
Description:
Add support for histograms with control plane metrics behind a feature gate.