Skip to content

Fix issue where SPLUNK_OTEL_AGENT env var was set before custom opeartor.instrumentation.spec.env #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2024
Merged

Fix issue where SPLUNK_OTEL_AGENT env var was set before custom opeartor.instrumentation.spec.env #1292

merged 2 commits into from
May 15, 2024

Conversation

jvoravong
Copy link
Contributor

Description:

  • This small bug fix makes it so customer provided env vars (using opeartor.instrumentation.spec.env) can use the env var SPLUNK_OTEL_AGENT with var substitution.
  • Before, SPLUNK_OTEL_AGENT was defined after the customer provided env vars and value var substitution was not possible.

@jvoravong jvoravong requested review from a team as code owners May 14, 2024 17:25
crobert-1
crobert-1 approved these changes May 14, 2024
View reviewed changes
@jvoravong jvoravong merged commit 019225c into main May 15, 2024
34 of 35 checks passed
@jvoravong jvoravong deleted the inst-update branch May 15, 2024 14:09
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jinja2 jinja2 jinja2 approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvoravong @jinja2 @crobert-1 @srv-gh-o11y-gdi