remove post-delete hook #1175
Merged
remove post-delete hook #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes post-delete hook which does not work as intended. The original intention of adding this hook seems to have been to remove acls set by an initContainer on log directories to allow custom user/group ids access. While this would be a good-to-have, the current approach of doing this as a helm uninstall hook is not appropriate. The current hook config runs a single pod which tries to remove acls from the log directories if the user/group as set in securityContext. This does not work as intended since we are only creating a single pod which will remove the acls from a single node in the cluster while the initContainer which modifies the acls was run as a daemonset targeting all nodes.