Skip to content

Bring back the default translations for kubelet metrics in EKS Fargate #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Bring back the default translations for kubelet metrics in EKS Fargate #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chloggen/fix-metrics-in-eks-fargate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: clusterReceiver
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Bring back the default translations for kubelet metrics in EKS Fargate
# One or more tracking issues related to the change
issues: [1174]
1 change: 0 additions & 1 deletion examples/distribution-eks-fargate/rendered_manifests/configmap-cluster-receiver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ data:
signalfx:
access_token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
api_url: https://api.CHANGEME.signalfx.com
disable_default_translation_rules: true
ingest_url: https://ingest.CHANGEME.signalfx.com
timeout: 10s
extensions:
Expand Down
2 changes: 1 addition & 1 deletion examples/distribution-eks-fargate/rendered_manifests/deployment-cluster-receiver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
component: otel-k8s-cluster-receiver
release: default
annotations:
checksum/config: d3643e9b340c14bccb45710fb7b6e67b5567254fa1c328d5af935ac13c8388bc
checksum/config: 32aa4177abaaf5dc6ff30813a4511cbfd7974b2a99c85da9a798175df36e8a18
spec:
serviceAccountName: default-splunk-otel-collector
nodeSelector:
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ exporters:
api_url: {{ include "splunk-otel-collector.o11yApiUrl" . }}
access_token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
timeout: 10s
{{- if not (eq (include "splunk-otel-collector.distribution" .) "eks/fargate") }}
disable_default_translation_rules: true
{{- end}}
{{- end }}

{{- if and (eq (include "splunk-otel-collector.o11yLogsEnabled" .) "true") (eq (include "splunk-otel-collector.objectsOrEventsEnabled" .) "true") }}
Expand Down