Adds a new API that can customize the ingest sender. #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@breedx-splk this approach will cover the functionality of #739. Thank you! |
johnbley
reviewed
Jan 29, 2024
|
|
||
| package com.splunk.rum.incubating; | ||
|
|
||
| import zipkin2.reporter.okhttp3.OkHttpSender; |
There was a problem hiding this comment.
Shucks, I was hoping this might be forward-compatible if/when we move to OTLP....
There was a problem hiding this comment.
Well, headers can be specified through OtlpHttpSpanExporterBuilder.setHeaders() and compression can be swizzled with OtlpHttpSpanExporterBuilder.setCompression().
These methods also exist on OtlpHttpLogRecordExporterBuilder, so I think we'll be ok.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to get access to the guts of the Zipkin
OkHttpSender.Builderin order to do things like add custom headers and control compression settings, etc. The sender used in both paths (with or without disk buffering) can be impacted by this customizer.It also includes a sample usage in the sample app.
This would ideally supersede #739. Thanks to @magdamagda for the original ideas and inspiration here.