MutableAttributes unit tests #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Chladek <[email protected]>
...common/src/main/java/com/splunk/rum/integration/agent/common/attributes/MutableAttributes.kt
Show resolved
Hide resolved
tonzhan2
approved these changes
Jun 3, 2025
surbhiia
requested changes
Jun 3, 2025
...common/src/main/java/com/splunk/rum/integration/agent/common/attributes/MutableAttributes.kt
Outdated
Show resolved
Hide resolved
|
|
||
| mutableAttributes.update { | ||
| put("updatedKey", "updatedValue") | ||
| remove(AttributeKey.stringKey("initialKey")) |
There was a problem hiding this comment.
For testing update, we should also try to update the value of key initialValue instead of removing it. You can add another key that gets removed.
There was a problem hiding this comment.
Actually I meant, we should add it here - in the update method test - a test for updating value of an existing key.
For example:
val mutableAttributes = MutableAttributes()
mutableAttributes["initialKeyTobeUpdated"] = "initialValueTobeUpdated"
mutableAttributes["initialKeyTobeRemoved"] = "initialValueTobeRemoved"
mutableAttributes.update {
put("updatedKey", "updatedValue")
put("initialKeyTobeUpdated", "newUpdatedValue")
remove(AttributeKey.stringKey("initialKeyTobeRemoved"))
put("anotherKey", 12345L)
}
There was a problem hiding this comment.
@surbhiia Tom is on PTO now. I’ll go ahead and merge this, but I’ll let him know and ask him to update it separately. Thanks for the review and approval!
Signed-off-by: Tomas Chladek <[email protected]>
surbhiia
approved these changes
Jun 4, 2025
|
Approved PR, but do see if you can add this - #1279 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MutableAttributes unit tests and fixes