Added support for Splunk Platform Integration and Notification #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration/model_type.go
Outdated
| WEBHOOK Type = "Webhook" | ||
| X_MATTERS Type = "XMatters" | ||
| SPLUNK_PLATFORM Type = "SplunkPlatform" |
There was a problem hiding this comment.
This should be inserted to line 34 to keep the values in an alphabetical order.
notification/model_notification.go
Outdated
There was a problem hiding this comment.
Please add tests around this to make sure it is correctly loaded.
durgeshsplunk
commented
Feb 24, 2025
There was a problem hiding this comment.
Added SplunkPlatform notification response under test response to serve as a test case for SplunkPlatform notification rule type
durgeshsplunk
force-pushed
the
master
branch
from
63c7d79 to
643ca0b
Compare
MovieStoreGuy
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to fetch detectors from my org as notification on one of the detectors was of the type SplunkPlatform and the signalfx-go module does not support it right now.
I have also added support form the Splunk Platform Integration.