This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Fix AzureUniqueID when VMSS is used #2126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AzureUniqueID
has been using the wrong strings functionTrimLeft
to find out the instanceID, instead we should stick toTrimPrefix
Little bit more description:
TrimLeft
removes the leading characters of a string that matches the cutset.In other words, it iterates through the string one character at a time, from left to right and checks if the character exists in the cutset (regardless of order), once it fails to find a char in the cutset it returns the index which is used to slice the string.
Problem in the example I showed, when all character of the string exists in the cutset.
Signed-off-by: Dani Louca [email protected]