This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Added and updated coredns metrics for metric name changes in coredns-1.7.0-release #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoravong
requested review from
asuresh4,
jeffreyc-splunk,
keitwb,
mstumpfx,
rmfitzpatrick and
a team
as code owners
mstumpfx
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Do I have to update other projects or docs for newly added metrics?
It looks like the following deprecated metrics are used in our built-in content:
coredns_dns_response_rcode_count_totalcoredns_dns_request_count_totalcoredns_cache_size
We should update that content to include the newer metrics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently when installing with the helm chart, we are planning to use signalfx receivers for monitoring Kubernetes control plane components. The coredns monitor in the signalfx agent is a little out of date, coredns updated several metric names in coredns-1.7.0-release. 4 of the metrics the signalfx coredns monitor had name changes. 3 of the metrics with new names are used in our k8s services dashboard.
Added new metrics and did not delete older metrics for backwards compatibility. I did update the descriptions of the deprecated metrics.
The project docs did get regenerated.
Questions:
Do I have to update other projects or docs for newly added metrics?