Remove dependency on appd-exts-commons #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
commented
Jun 4, 2025
| @@ -70,7 +69,7 @@ private void addEnvProperty(Hashtable env, String propName, Object propVal) { | |||
| if (null != propVal) { | |||
| if (propVal instanceof String) { | |||
| String propString = (String) propVal; | |||
| if (Strings.isNullOrEmpty(propString)) { | |||
| if (propString.isEmpty()) { | |||
There was a problem hiding this comment.
this reads like a potential semantic change, but the cast would NPE above, so we're already guarded against the null.
atoulme
approved these changes
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was being used just to source a couple of transitive dependencies, including snakeyaml, jackson, and guava. The guava usages were minimal, so I just replaced those with standard java calls. We depend on snakeyaml and jackson explicitly now.