Skip to content

move to go 1.19, latest github actions, and golangci-lint #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2023
Merged

move to go 1.19, latest github actions, and golangci-lint #249

merged 5 commits into from
Apr 28, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Apr 28, 2023

No description provided.

@atoulme atoulme requested review from a team as code owners April 28, 2023 00:06
@benkeith-splunk
Copy link

Looks fine except for the one remaining lint issue.

jgheewala
jgheewala reviewed Apr 28, 2023
View reviewed changes
jgheewala
jgheewala approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@jgheewala jgheewala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm only thing i am worried about is removing the 100% coverage check.

@atoulme atoulme changed the title move to go 1.19 and remove code coverage check move to go 1.19, latest github actions, and golangci-lint Apr 28, 2023
@atoulme atoulme merged commit 985f880 into main Apr 28, 2023
@atoulme atoulme deleted the fix_ci branch May 2, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgheewala jgheewala jgheewala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @benkeith-splunk @jgheewala