Fix potential buffer overflow in insert_many
#254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Pushed a different version of the fix. This is a more invasive change, but it leaves the code a bit simpler and much easier to reason about. The key observation is that the guard is no longer needed after we fill up the initial |
emilio
approved these changes
Jan 8, 2021
Member
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
r=me with that change unless I'm missing something.
Collaborator
Author
|
@bors-servo r=emilio |
Contributor
|
📌 Commit 9998ba0 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252.