Skip to content

Publish match_token 0.1.1 #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Publish match_token 0.1.1 #621

merged 2 commits into from
Jun 20, 2025

Conversation

jdm
Copy link
Member

@jdm jdm commented Jun 20, 2025

This version includes a change that's required to build the newest version of html5ever.

jdm added 2 commits June 20, 2025 01:22
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
@jdm jdm added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit fe058bc Jun 20, 2025
6 checks passed
@Quentin01
Copy link

Quentin01 commented Jun 20, 2025

Just so you know @jdm, as you published this ~45 minutes ago, you broke the install of mdbook as you didn't yet published the new version of html5ever and markup5ever yet. I hope you will publish those new versions ASAP.

This version contains a breaking change from #593, it should have been a bump in the minor version instead of the patch.

@jdm
Copy link
Member Author

jdm commented Jun 20, 2025

@Quentin01 I apologize for the problems. This all started with attempting to release a new version of html5ever and discovering multiple that publishing was broken while normal cargo builds worked fine. We're going to sort out a better system to avoid this in the future.

@nicoburns
Copy link
Contributor

@jdm I suspect this problem arising means that the new version of match_token is semver breaking and ought to be published as 0.2 (with 0.1.1 yanked).

(even once the new version of html5ever is published the old version ought to continue to work)

@Quentin01
Copy link

I opened an issue before seeing your comments. I should have probably waited more, but we can probably use it to discuss this issue further. I'm glad to know you are on it and that you will sort this out. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants