Skip to content

Conversation

@nblumhardt
Copy link
Member

No description provided.

@nblumhardt
Copy link
Member Author

Working my way through the 8.0.0 releases; this is pretty low in the dependency graph so pushing this through :-)

@nblumhardt
Copy link
Member Author

If anyone has a chance to check out the build/test failures - I'm not very familiar with how TestApp is set up/used, it'd be great to have some more eyes on it :-)

@0xced
Copy link
Member

0xced commented Nov 15, 2023

I'll look into it.

@nblumhardt
Copy link
Member Author

Think I have it sorted - thanks @0xced!

@nblumhardt
Copy link
Member Author

Build.ps1 was using a direct .dll invocation to kick off tests, something in that mode prevents [CallerFilePath] from being compiled in correctly; running dotnet test against the CSPROJ is fine.

@nblumhardt nblumhardt merged commit 7fc0d58 into serilog:dev Nov 15, 2023
@nblumhardt nblumhardt mentioned this pull request Nov 15, 2023
{
"sdk": {
"version": "8.0.100-rc.2.23502.2"
"version": "8.0.100"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably restore "rollForward": "latestFeature" (and maybe "allowPrerelease": false).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will do on the next round if you don't beat me to it :-) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants