Skip to content

Added support for appsettings configuration #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nrandell
Copy link

PR for issue #5 that adds in functionality to use the appsettings in a single line

@nrandell
Copy link
Author

I've removed the additional dependency to serilog.settings.configuration, and created a logger builder extension to add serilog. This keeps the original package nice and clean.
The example now uses

.UseSerilog(configuration =>
    new Serilog.LoggerConfiguration()
        .ReadFrom.Configuration(configuration)
        .CreateLogger()
)

@nblumhardt
Copy link
Member

Thanks for pushing ahead with this one, @nrandell 👍

I think this has become effectively a duplicate of #1, where there's already been a bit more discussion around trade-offs. I think we should close this PR (sorry!) and pick things up over there. Sound like a plan?

@nrandell
Copy link
Author

nrandell commented Oct 4, 2017

I've just read #1 a bit more carefully @nblumhardt and it makes sense. So I'm happy to close this - it's good to see that a number of us have come to the same conclusions separately! We must be doing something right!

@nrandell nrandell closed this Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants