Add support for voice status #2982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
builder
arqunis
added
enhancement
arqunis
requested changes
Oct 5, 2024
Member
arqunis
left a comment
arqunis
left a comment
There was a problem hiding this comment.
Looks good, but could you change the use of the json! macro to an intermediary struct? We like to avoid temporary heap allocations as much as possible.
Co-authored-by: Alex M. M. <[email protected]>
arqunis
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't seen any docs to change voice status in this crate.
API here: discord/discord-api-docs#6400
This patch makes changing voice status possible. Not familiar with the code base, so I'm not sure if this is the best way to do it.