Write depth buffer & view to registered RenderBuffer #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depthStencilTextures and depthStencilViews vectors seem to be deprecated but leave for now
russell-taylor
requested changes
Feb 7, 2018
Contributor
russell-taylor
left a comment
russell-taylor
left a comment
There was a problem hiding this comment.
I guess it makes sense to go ahead and tell the RenderManager about the depth/stencil buffer but if we're doing that then it seems like it would also make sense to change the call to RenderView to get that information back out of the renderBuffers structure rather than continuing to send it directly.
There is at least one other example that uses this same approach that we could also change to work this way.
russell-taylor
requested changes
Feb 7, 2018
Contributor
russell-taylor
left a comment
russell-taylor
left a comment
There was a problem hiding this comment.
I checked, and it does indeed work to pull the view from the RenderInfo, so if you add that I'll go ahead and approve the request. We can then open an issue to change the other files to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depthStencilTextures and depthStencilViews vectors seem to be deprecated but leave for now