Skip to content

Conversation

@rpavlik
Copy link
Member

@rpavlik rpavlik commented Oct 13, 2016

This contains, among other fixes, an updated FindJsonCpp.cmake script from OSVR-Core - the same one that has been tested to work with the stock Ubuntu 16.04 package of JsonCpp - this should fix #250

@russell-taylor can you verify?

@russell-taylor
Copy link
Contributor

Well, when I try it on my home Linux box, it now causes CMake 3.2.2 to crash on configure when I try the second configure step. Of course, so does master...

ccmake: ../../Source/cmTarget.cxx:58: static const char* cmTarget::GetTargetTypeName(cmTarget::TargetType): Assertion `0 && "Unexpected target type"' failed.
Aborted (core dumped).

Will check on another host.

@russell-taylor
Copy link
Contributor

On my other desktop with Ubuntu 16.04 and CMake 3.5.1, both master and this pull request work fine. Will need to wait until my compile job finishes on my laptop to reboot and test the compile in Linux on it, where the non-crash failure happened before.

@russell-taylor
Copy link
Contributor

On the Ubuntu 04.04.5 laptop running cmake version 3.4.1, I get the same error message with both master and this pull request branch. It works fine for the first configure after each run of ccmake but fails on the second with:

CMake Error at CMakeLists.txt:456 (target_link_libraries):
Target "JsonCpp::JsonCpp" of type

@rpavlik
Copy link
Member Author

rpavlik commented Oct 17, 2016

Are you using the system provided packages for jsoncpp and CMake? (If so I
can try to repro in docker and test locally)

On Sat, Oct 15, 2016, 8:18 AM Russell Taylor [email protected]
wrote:

On the Ubuntu 04.04.5 laptop running cmake version 3.4.1, I get the same
error message with both master and this pull request branch. It works fine
for the first configure after each run of ccmake but fails on the second
with:

CMake Error at CMakeLists.txt:456 (target_link_libraries):
Target "JsonCpp::JsonCpp" of type


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#252 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADuydU6CLMhEEBo11bDQXWZec5q7E8hks5q0NK3gaJpZM4KWVDf
.

Ryan A. Pavlik, Ph.D.
CTO - OSVR Platform
Sensics, Inc.
www.sensics.com

Latest news and blog posts (subscribe here
http://sensics.com/subscribe-to-our-mailing-list/ to get weekly updates):

Oct 14: Peeking inside the Goggles for Public VR
http://sensics.com/goggles-public-vr-pre-production-run/

Sep 13: Why WebVR? http://sensics.com/why-webvr/

Aug 30: TechCrunch: VR from the battlefield to the couch and back
https://techcrunch.com/2016/08/30/vr-on-the-battlefield-to-the-couch-and-back-again-sort-of/

@russell-taylor
Copy link
Contributor

I'm using the system packages on Linux

On Oct 16, 2016 11:19 PM, "Ryan Pavlik" [email protected] wrote:

Are you using the system provided packages for jsoncpp and CMake? (If so I
can try to repro in docker and test locally)

On Sat, Oct 15, 2016, 8:18 AM Russell Taylor [email protected]
wrote:

On the Ubuntu 04.04.5 laptop running cmake version 3.4.1, I get the same
error message with both master and this pull request branch. It works
fine
for the first configure after each run of ccmake but fails on the second
with:

CMake Error at CMakeLists.txt:456 (target_link_libraries):
Target "JsonCpp::JsonCpp" of type


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#252
issuecomment-253983824>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AADuydU6CLMhEEBo11bDQXWZec5q7E8hks5q0NK3gaJpZM4KWVDf>
.

Ryan A. Pavlik, Ph.D.
CTO - OSVR Platform
Sensics, Inc.
www.sensics.com

Latest news and blog posts (subscribe here
http://sensics.com/subscribe-to-our-mailing-list/ to get weekly
updates):

Oct 14: Peeking inside the Goggles for Public VR
http://sensics.com/goggles-public-vr-pre-production-run/

Sep 13: Why WebVR? http://sensics.com/why-webvr/

Aug 30: TechCrunch: VR from the battlefield to the couch and back
<https://techcrunch.com/2016/08/30/vr-on-the-battlefield-
to-the-couch-and-back-again-sort-of/>


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#252 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuh0Pk0DYAHR9W2yGoiNOiZkQzMaAVRks5q0ulXgaJpZM4KWVDf
.

@russell-taylor
Copy link
Contributor

Anything new to try here?

@rpavlik rpavlik mentioned this pull request Jan 6, 2017
@rpavlik
Copy link
Member Author

rpavlik commented Jan 6, 2017

Replaced with a new PR.

@rpavlik rpavlik closed this Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newest master has broken build on Linux from a clean clone

3 participants