-
Notifications
You must be signed in to change notification settings - Fork 46
Update shared cmake files from upstream repo #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well, when I try it on my home Linux box, it now causes CMake 3.2.2 to crash on configure when I try the second configure step. Of course, so does master... ccmake: ../../Source/cmTarget.cxx:58: static const char* cmTarget::GetTargetTypeName(cmTarget::TargetType): Assertion `0 && "Unexpected target type"' failed. Will check on another host. |
|
On my other desktop with Ubuntu 16.04 and CMake 3.5.1, both master and this pull request work fine. Will need to wait until my compile job finishes on my laptop to reboot and test the compile in Linux on it, where the non-crash failure happened before. |
|
On the Ubuntu 04.04.5 laptop running cmake version 3.4.1, I get the same error message with both master and this pull request branch. It works fine for the first configure after each run of ccmake but fails on the second with: CMake Error at CMakeLists.txt:456 (target_link_libraries): |
|
Are you using the system provided packages for jsoncpp and CMake? (If so I On Sat, Oct 15, 2016, 8:18 AM Russell Taylor [email protected]
Latest news and blog posts (subscribe here Oct 14: Peeking inside the Goggles for Public VR Sep 13: Why WebVR? http://sensics.com/why-webvr/ Aug 30: TechCrunch: VR from the battlefield to the couch and back |
|
I'm using the system packages on Linux On Oct 16, 2016 11:19 PM, "Ryan Pavlik" [email protected] wrote:
|
|
Anything new to try here? |
|
Replaced with a new PR. |
This contains, among other fixes, an updated FindJsonCpp.cmake script from OSVR-Core - the same one that has been tested to work with the stock Ubuntu 16.04 package of JsonCpp - this should fix #250
@russell-taylor can you verify?