Skip to content

fix: Support 204 response in axios #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Support 204 response in axios #1428

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
600b377
fix: Support 204 response in axios
lopenchi Feb 18, 2025
d42dbc5
do not skip tests with 204 response
lopenchi Feb 18, 2025
df5f163
revert unneeded change
lopenchi Feb 18, 2025
e4bfac8
Merge branch 'main' into DOCSPLAT-1860
tiwarishubham635 Feb 19, 2025
aef7441
Fix for 204 responses
lopenchi Mar 21, 2025
06408e4
Merge branch 'DOCSPLAT-1860' of github.com:lopenchi/sendgrid-nodejs i…
lopenchi Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/client/src/classes/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,11 @@ class Client {
data = this.createRequest(data);

const promise = new Promise((resolve, reject) => {
axios(data)
axios(data, {
validateStatus: function (status) {
return status >= 200 && status < 300 || status === 204;
},
})
.then(response => {
return resolve([
new Response(response.status, response.data, response.headers),
Expand Down
Loading