Skip to content

Re-do #71 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2018
Merged

Re-do #71 #81

merged 1 commit into from
Jan 2, 2018

Conversation

delirious-lettuce
Copy link
Contributor

Re-submit #71 with a couple extra updates

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Use triple double-quotes for docstrings (PEP 257)

  • Fix typos

    old new
    erro error
    existance existence
    successsful successful

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@delirious-lettuce
* Use triple double-quotes for docstrings (PEP 257)
19fedce 
* Fix typos:
  `erro` | `error`
  `existance` | `existence`
  `successsful` | `successful`
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 2, 2018
@thinkingserious thinkingserious merged commit 8267834 into sendgrid:master Jan 2, 2018
@thinkingserious
Copy link
Contributor

Hello @delirious-lettuce,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@delirious-lettuce delirious-lettuce deleted the docstring_quotes branch January 2, 2018 22:57
@delirious-lettuce
Copy link
Contributor Author

@thinkingserious ,

Sure, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delirious-lettuce @thinkingserious