Skip to content

Update travis - add codecov #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2017
Merged

Conversation

pushkyn
Copy link
Contributor

@pushkyn pushkyn commented Oct 30, 2017

Fixes #70

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@pushkyn pushkyn force-pushed the add-travis-codecov branch from f958a7b to 7ba11d2 Compare October 31, 2017 18:33
@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@01bba17). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage          ?   91.73%           
=========================================
  Files             ?        4           
  Lines             ?      254           
  Branches          ?        0           
=========================================
  Hits              ?      233           
  Misses            ?       21           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01bba17...ec45ba2. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@48627ec). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage          ?   91.73%           
=========================================
  Files             ?        4           
  Lines             ?      254           
  Branches          ?        0           
=========================================
  Hits              ?      233           
  Misses            ?       21           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48627ec...7ba11d2. Read the comment docs.

@mbernier mbernier added the difficulty: easy fix is easy in difficulty label Dec 11, 2017
@mbernier
Copy link
Contributor

YES!

@mbernier mbernier merged commit b3b7b93 into sendgrid:master Dec 21, 2017
@thinkingserious
Copy link
Contributor

Hello @pushkyn,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeCov support to .travis.yml
4 participants