-
Notifications
You must be signed in to change notification settings - Fork 102
Conformance to style standards #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance to style standards #100
Conversation
Please rebase and address conflicts. Thanks! |
How about moving That way any issues found will fail the build, meaning they will have to be fixed and won't sneak into the codebase. |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 6 6
Lines 293 293
=======================================
Hits 268 268
Misses 25 25
Continue to review full report at Codecov.
|
Just fixed both situations @misterdorm and @hugovk . I appreciate your suggestions. I just have a question about "50% of diff hit (target 91.46%)" on code checks. It's about the coverage of my code? I haven't changed any logic on code, it's necessary to me to develop unit tests about the lines I changed? |
Hello @moshemeirelles, |
Fixes #94
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.