Skip to content

Conformance to style standards #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2018
Merged

Conformance to style standards #100

merged 3 commits into from
Nov 14, 2018

Conversation

mosesmeirelles
Copy link
Contributor

@mosesmeirelles mosesmeirelles commented Oct 8, 2018

Fixes #94

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • made changes in files as suggested by pycodestyle following PEP8 code compliance
├── python_http_client
│   └── client.py
└── tests
    └── test_daterange.py

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 8, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 8, 2018

CLA assistant check
All committers have signed the CLA.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty hacktoberfest and removed status: code review request requesting a community code review or review from Twilio labels Oct 12, 2018
@misterdorm
Copy link
Contributor

Please rebase and address conflicts. Thanks!

@hugovk
Copy link
Contributor

hugovk commented Oct 20, 2018

How about moving pycodestyle from the after_script: section to the script: section?

That way any issues found will fail the build, meaning they will have to be fixed and won't sneak into the codebase.

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files           6        6           
  Lines         293      293           
=======================================
  Hits          268      268           
  Misses         25       25
Impacted Files Coverage Δ
python_http_client/client.py 77.66% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45c299...75d053e. Read the comment docs.

@mosesmeirelles
Copy link
Contributor Author

mosesmeirelles commented Oct 26, 2018

Just fixed both situations @misterdorm and @hugovk . I appreciate your suggestions.

I just have a question about "50% of diff hit (target 91.46%)" on code checks. It's about the coverage of my code? I haven't changed any logic on code, it's necessary to me to develop unit tests about the lines I changed?
Any help would be appreciated 🙂

@thinkingserious thinkingserious merged commit 3fae8b8 into sendgrid:master Nov 14, 2018
@thinkingserious
Copy link
Contributor

Hello @moshemeirelles,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require conformance to style standards
5 participants