Skip to content

Test of date range in license file #121

Closed
@frenzymadness

Description

@frenzymadness

I would like to discuss whether is a good idea to have a test which is testing date range (Copyright (c) 2012 - 2019 SendGrid, Inc.). I understand the need described in the original issue (#57) but I don't think that it's a good idea to have a unit test for that.

HTTP client is packaged in various Linux distributions. Now imagine that you have packaged HTTP client version from 2018 and you want just a rebuild that package in 2019. It'll fail.
Also, when you create a first pull request after a new year with some bugfix or a new feature, the tests will fail and it's not your fault.

Some workaround might be to change the date range in license file as a first thing every year but you probably don't want to release a new version and without a new version, nobody will update until they have to.

There is a PR to fix the problem now (#120) but I'd rather remove that test entirely. If it's really necessary to test it, it might be possible to move it to Travis config so it'd tested only in CI and not with unit tests.

What do you think?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions