Whisper service device config #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12
Created a new
device_config.json
configuration file.Format is as follows.
implementation_id
is unique for each model implementation.model_implementations/import_model_implementation.py
contains the mappings fromimplementation_id
to model implementation.TranscriptionModelBase
requires a new methodvalidate_config()
that is used to validate if configuration object contains all expected fields when a model is instantiated.init_device_config.py
parses thisdevice_config.json
and for every model, instantiates the model and callload_model()
andunload_model()
.model_factory.py
has been modified to look upmodel_key
in device config instead of hard coded mappings.