-
Notifications
You must be signed in to change notification settings - Fork 83
Implement Conjugate for Swedish and Russian #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Conjugate for Swedish and Russian #438
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
a337673
to
5aa327e
Compare
I have made the changes. It is ready for review. |
A couple of quick comments here, @angrezichatterbox :)
![]() I think we should be good after these changes come in! |
I will add these changes in a while. |
Could this modification be temporary made to the contract ? |
In that case this is ready for review. |
I would have to make that change as the currently the entire top small label is being singly set using the a single logic rather than being key wise. |
I'm ok with the change to the contract, @angrezichatterbox, but it looks like we still have UI issues regardless, and maybe something from the recent commits is also not interacting well with the height of the conjugation buttons: ![]() Could we get the labels over the buttons and have the combined height of the buttons span the height of the conjugation display? |
I will have it fixed right away. |
Nice! Looking forward to bringing this in, @angrezichatterbox! 😊 |
Can I Know which Device is it being tested on ? |
Pixel 9 API 35 :) |
It is ready for review :) |
I would bring in @DeleMike suggestion in this PR. |
The one about the text sizes of the keys? Feel free to add that in! |
Hi @angrezichatterbox I've looked at the conjugation section and all looks good to me! or is there a specific section of conjugation you want me to take a look at See a video recording: Screenrecorder-2025-08-10-18-04-16-222.mp4 |
This is ready for review then. Thanks @DeleMike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good now, @angrezichatterbox :) The buttons and labels might still need a bit of work before we release as they're still not exactly aligned at the bottom and the labels go over the edge the slightest bit, but nothing to worry about right now 😊 Thanks for your continued efforts! Let's get English done and then we can maybe create help wanted
issues to finalize the minor display things there or even check it out during a sync :)
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
This PR adds conjugate support for Swedish and Russian language and fixes the bugs present in the German conjugate mode that caused it to not produce the right output for Perfect tenses.
Related issue