-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[MRG] EHN refactoring of the ratio argument. #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
166f183
EHN add ratio as a float and refactor tests
glemaitre 452926e
FIX add new way of sampling
glemaitre dff36e7
Check deprecation warning
glemaitre 8ef9416
TST fix test
glemaitre f3fef5c
FIX depreacte ratio and ratio_
glemaitre c12805c
FIX rename the different functions
glemaitre 311b269
TST udpate test and deprecating
glemaitre 596a475
FIX use check_sampling_target internally instead of check_ratio
glemaitre f5a1254
DOC add check_sampling_target into the API
glemaitre 00fc0bb
DOC update all docstring
glemaitre fcf8b29
DOC update ratio example
glemaitre b11e154
DOC remove ratio occurences
glemaitre 1fe87df
EXA add example sampling target
glemaitre 8157bd7
FIX test remove ratio from the test
glemaitre 78f91a0
EXA fix underline
glemaitre b5c91c4
DOC add whatsnew entry
glemaitre db3f550
DOC udpate whats new
glemaitre 199f320
add docstring substitution
glemaitre 89e27d9
iter
glemaitre 7ebfb68
DOC factorize docstring
glemaitre e5a4dd3
joris comments
glemaitre 4ba215d
TST add tests for injection in docstring
glemaitre 0bf8f85
go back to old type class for python 2
glemaitre 09c5aaa
Rename and PEP8
glemaitre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change
remove the sample from
forremove samples from
. + I don't really understand whatcontrol which sample of the link will be removed
means.link
confuses me