Skip to content

fix: dask distributed fsspec issue #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2023
Merged

fix: dask distributed fsspec issue #1065

merged 5 commits into from
Dec 13, 2023

Conversation

lobis
Copy link
Collaborator

@lobis lobis commented Dec 13, 2023

@lobis lobis added the next-release Required for the next release label Dec 13, 2023
@lobis lobis changed the title fix: dask distributed fix: dask distributed fsspec issue Dec 13, 2023
@lobis lobis requested a review from jpivarski December 13, 2023 19:37
@lobis lobis marked this pull request as ready for review December 13, 2023 19:37
@lobis
Copy link
Collaborator Author

lobis commented Dec 13, 2023

@lgray I think this is done, let me know of it works fine!

@lgray
Copy link
Contributor

lgray commented Dec 13, 2023

looks good to me! please merge :-)

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I'll merge it now.

@jpivarski jpivarski merged commit 9d597dc into main-fsspec Dec 13, 2023
@jpivarski jpivarski deleted the issue_1063 branch December 13, 2023 21:23
jpivarski pushed a commit that referenced this pull request Dec 13, 2023
* add dask distributed to dev dependencies

* work on test for issue 1063

* test multiple handlers

* file handle pickling

* clear file handle before pickling
lobis added a commit that referenced this pull request Jan 22, 2024
* origin/main: (41 commits)
  chore: hatch-vcs generates 'version.py'; add it to .gitignore
  docs: add bnavigator as a contributor for test (#1087)
  feat: support for writing hist derived profiles (#1000)
  feat: add the ability to read RNTuple alias columns (#1004)
  chore: update pre-commit hooks (#1082)
  docs: fix ReadTheDocs documentation (#1084)
  chore: update pre-commit hooks (#1073)
  chore(deps): bump actions/upload-artifact from 3 to 4 (#1071)
  chore(deps): bump actions/download-artifact from 3 to 4 (#1072)
  build: change build to autogen version info (#1062)
  chore: remove src/uproot/version.py (for #1062).
  The next release will be 5.2.1.
  add known_base_form option so that opening root files can be avoided for mature analyses (#1077)
  test: fsspec cache (#1075)
  test: xrootd server fixture (#1076)
  The next release will be 5.2.0.
  fix: correct typo in fsspec globbing (#1067)
  chore(deps): bump actions/setup-python from 4 to 5 (#1059)
  The next release will be 5.2.0rc5.
  fix: dask distributed fsspec issue (#1065)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release Required for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urgent: uproot.dask(..., open_files=True) not usable with dask distributed client
3 participants