This repository was archived by the owner on Jan 7, 2023. It is now read-only.
[MRG] numpy dependency in setup.py #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a requirements.txt file with root_numpy[with-numpy])
ndawe
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add numpy to setup's extras_require to make explicit dependency optional:
Useful for a requirements.txt file with root_numpy[with-numpy]. Exactly how scikit-learn implements optional explicit dependency on numpy in setup.py: http://scikit-learn.org/stable/install.html
Put numpy in setup's setup_requires and install_requires lists only if not already installed.
Prevents pip from upgrading an existing numpy installation.
This is what scipy does.