Skip to content

Make suggested_init, suggested_bounds and suggested_fixed property attributes #2028

Open
@matthewfeickert

Description

@matthewfeickert

Similarly to this, suggested_init, suggested_bounds and suggested_fixed currently take no arguments either. One other consideration is that maybe some of these parts of the API are meant to eventually support kwargs, in which case switching to a property would not be useful.

Originally posted by @alexander-held in #1700 (comment)

This is a good idea and should be done, but this would cause more breaks in pyhf v0.7.0 then I think we want

$ git grep --name-only "suggested_init()" | wc -l
42

So I think these should hold off until v0.8.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    APIChanges the public APIfeat/enhancementNew feature or requestneeds-triageNeeds a maintainer to categorize and assign

    Type

    No type

    Projects

    Status

    To do

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions