-
Notifications
You must be signed in to change notification settings - Fork 519
add GitHub workflow that sets up a React Native project with the library #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @sbugert, can you maybe sign up for the GitHub Actions beta, so I can use it in this repo? https://github.com/features/actions Signup should be immediately accepted. |
|
Hey @koenpunt, I've already signed up quite a while ago, I don't understand why the workflow does not show up in the Actions tab. We could try changing the default branch to ci for a test? Edit: Do you see the Actions tab next to the Pull requests link? |
|
I was thinking similar things, but when I pushed it to my fork, it just worked; https://github.com/koenpunt/react-native-admob/runs/233747514 So not sure what the issue is, maybe they are still gradually updating users from the old format to the yaml format... Btw, I'm seeing this banner in the repo; So maybe you can change something in the settings of the repo? |
Yeah I'm quite done with users saying "it doesn't work", while for me it works just fine. So I figured if I can demonstrate it's working on CI, I can simply refer to that :) |
I don't see a banner but I can click on the actions tab. But it only let's me create a new workflow there. And I did not find any settings related to actions. Does it already work correctly for your fork? Then, I guess there's no reason not to try merging it to master and see if it works then. Or we could just wait to see if they're really still migrating the users :) |
0e6fb08 to
e28702c
Compare
|
I've finalised the config, and it's running correctly on my fork: https://github.com/koenpunt/react-native-admob/commit/250daa4dc296d27e0072fe9a8cfddf6d9dddca9c/checks |
The UITests have been updated to assert ads are rendered. Something similar has to be done for Android implementation.
|
CI is working now! I was thinking to build it on a schedule, like every 7 days or so. What do you think? |
|
Looks great! I can see it now in the actions tab. Maybe because it's not a draft PR anymore? Running it every 7 days sounds good. |
That, or the React Native implementation changes. But both are good to know early on of course. |

I've updated the UI Tests in the iOS project to assert an ad being rendered, and setup up GitHub CI to run these tests.