Skip to content

Conversation

@koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Sep 23, 2019

I've updated the UI Tests in the iOS project to assert an ad being rendered, and setup up GitHub CI to run these tests.

@koenpunt
Copy link
Collaborator Author

Hey @sbugert, can you maybe sign up for the GitHub Actions beta, so I can use it in this repo?

https://github.com/features/actions

Signup should be immediately accepted.

@sbugert
Copy link
Owner

sbugert commented Sep 24, 2019

Hey @koenpunt, I've already signed up quite a while ago, I don't understand why the workflow does not show up in the Actions tab.
Maybe it still only works for the default branch? According to this thread it's still unclear to me if this is already a feature.

We could try changing the default branch to ci for a test?
Btw great idea and thanks for all the work! :)

Edit: Do you see the Actions tab next to the Pull requests link?

@koenpunt
Copy link
Collaborator Author

koenpunt commented Sep 24, 2019

I was thinking similar things, but when I pushed it to my fork, it just worked; https://github.com/koenpunt/react-native-admob/runs/233747514

So not sure what the issue is, maybe they are still gradually updating users from the old format to the yaml format...

Btw, I'm seeing this banner in the repo;

image

So maybe you can change something in the settings of the repo?

@koenpunt
Copy link
Collaborator Author

Btw great idea

Yeah I'm quite done with users saying "it doesn't work", while for me it works just fine. So I figured if I can demonstrate it's working on CI, I can simply refer to that :)

@sbugert
Copy link
Owner

sbugert commented Sep 26, 2019

Btw, I'm seeing this banner in the repo;
So maybe you can change something in the settings of the repo?

I don't see a banner but I can click on the actions tab. But it only let's me create a new workflow there. And I did not find any settings related to actions.

Does it already work correctly for your fork? Then, I guess there's no reason not to try merging it to master and see if it works then. Or we could just wait to see if they're really still migrating the users :)

@koenpunt koenpunt force-pushed the ci branch 6 times, most recently from 0e6fb08 to e28702c Compare September 27, 2019 09:34
@koenpunt koenpunt marked this pull request as ready for review September 27, 2019 09:36
@koenpunt
Copy link
Collaborator Author

I've finalised the config, and it's running correctly on my fork: https://github.com/koenpunt/react-native-admob/commit/250daa4dc296d27e0072fe9a8cfddf6d9dddca9c/checks

The UITests have been updated to assert ads are rendered. Something similar has to be done for Android implementation.
@koenpunt
Copy link
Collaborator Author

koenpunt commented Oct 1, 2019

CI is working now! I was thinking to build it on a schedule, like every 7 days or so. What do you think?

@sbugert
Copy link
Owner

sbugert commented Oct 2, 2019

Looks great! I can see it now in the actions tab. Maybe because it's not a draft PR anymore?

Running it every 7 days sounds good.
The only reason for it to break is Google changing something, isn't it?

@koenpunt
Copy link
Collaborator Author

koenpunt commented Oct 2, 2019

The only reason for it to break is Google changing something, isn't it?

That, or the React Native implementation changes. But both are good to know early on of course.

@koenpunt koenpunt merged commit b160473 into master Oct 2, 2019
@koenpunt koenpunt deleted the ci branch October 2, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants