Skip to content

Conversation

@sdelliot
Copy link
Collaborator

Refactoring to adjust how cycles are detected and output to users.

Description

Discovered as part of sandialabs/firewheel_repo_base#3, this PR refactors where cycles in the dependency graph are checked and assists in clearly printing this information for users, should a cycle appear.

Related Issue

N/A

Type of Change

Please select the type of change your pull request introduces:

  • Bugfix
  • New feature
  • Documentation update
  • Other (please describe): Refactor

Checklist

  • This PR conforms to the process detailed in the Contributing Guide.
  • I have included no proprietary/sensitive information in my code.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested my code.

Additional Notes

N/A

@github-actions github-actions bot added the refactor A code change that neither fixes a bug nor adds a feature label Nov 24, 2025
@sdelliot sdelliot requested a review from mitchnegus November 24, 2025 22:07
@sdelliot sdelliot changed the title Refactor: Refactoring to adjust how cycles are detected and output to users. refactor: Refactoring to adjust how cycles are detected and output to users. Nov 24, 2025
@sdelliot sdelliot marked this pull request as draft November 25, 2025 12:15
@sdelliot sdelliot marked this pull request as ready for review November 25, 2025 16:34
@sdelliot sdelliot requested a review from gregjacobus December 15, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor A code change that neither fixes a bug nor adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants