-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
This ticket is mainly for backwards compatibility. Since we are iterating on a large amount of majors while still supporting the already hand validated majors in the GraduateNU's backend, we need to ensure:
- Changes we make to fix the newer majors doesn't break the old ones
- Have fix for hand validated errors that the scraper can handle
Current tests in scrapers are fairly rudimentary and doesn't address many edge cases that the major catalog is notorious for.
A few guidelines
- Errors that are mainly parser responsibility, i.e. the tokens are correct but the parser parses it incorrectly should be tests in
parse.test.ts - Errors that stems from tokens being wrong (not tokenizing a comment as a XOM, etc) should be in
tokenize.test.ts - Snapshot tests should be reserved for majors that has a distinct quality (Business with their separated concentration pages, etc)
Metadata
Metadata
Assignees
Labels
No labels