Skip to content

Conversation

@github-actions
Copy link

This is an automated PR created because AWS compliances resources were updated.

@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 1e4aa81 to f50cdcb Compare May 1, 2021 00:09
@jdyke jdyke mentioned this pull request May 3, 2021
@jdyke
Copy link
Collaborator

jdyke commented May 3, 2021

@kmcquade I know you're OOO so can I approve / merge this? Anything special I need to kickoff manually afterwards?

@kmcquade
Copy link
Collaborator

kmcquade commented May 3, 2021

@jdyke I updated your repository permissions to Maintainer instead of Triager. You should be able to make modifications.

I am not sure why the unit tests aren’t running on this. I’d like to make sure those run successfully before merging. The GitHub action for tests is supposed to run on push and pull request. Easiest temporary fix would be to modify the Readme or push an empty commit, since I’m not aware of a GitHub equivalent for “Jenkins retest this please”. Feel free to do either temp fix or to debug the GitHub action thing, it is up to you :)

@jdyke
Copy link
Collaborator

jdyke commented May 3, 2021

@jdyke I updated your repository permissions to Maintainer instead of Triager. You should be able to make modifications.

Roger, I'll dig into the unit tests! Thanks for the update.

@jdyke jdyke merged commit bdaffc2 into main May 3, 2021
@jdyke jdyke deleted the create-pull-request/patch branch May 3, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants